[node-patches] Change in ovirt-node[master]: network: Fix NIC.is_configured()

[fabiand at fedoraproject.org]

Fabian Deutsch has uploaded a new change for review.

Change subject: network: Fix NIC.is_configured()
......................................................................

network: Fix NIC.is_configured()

Previously a NIC was only assumed to be configured if a bootprotocol was
given. But this is wrong for the static IP cases, when no bootprotocol
but an IP address are set.
Thus the logic is updated and a NIC is assumed to be configured when a
bootprotocol or an IP address is set.

The symptoms were that the NIC appeared as unconfigured in the network
page, when a static IP was set.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=980465
Change-Id: Ic2d3e2d4ddb75958dd7cbb67bb29a305cc6d2411
Signed-off-by: Fabian Deutsch <fabiand at fedoraproject.org>
---
M src/ovirt/node/utils/network.py
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/07/16507/1

diff --git a/src/ovirt/node/utils/network.py b/src/ovirt/node/utils/network.py
index 4c8b922..e063862 100644
--- a/src/ovirt/node/utils/network.py
+++ b/src/ovirt/node/utils/network.py
@@ -221,7 +221,8 @@
     def is_configured(self):
         """If there is a configuration for this NIC
         """
-        return self.config.bootproto is not None
+        return self.config.bootproto is not None or \
+            self.config.ipaddr is not None
 
     def has_link(self):
         """Determin if L1 is up on a given interface


-- 
To view, visit http://gerrit.ovirt.org/16507
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic2d3e2d4ddb75958dd7cbb67bb29a305cc6d2411
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>