[node-patches] Change in ovirt-node[master]: ui: Always enable NIC independent fields

[fabiand at fedoraproject.org]

Fabian Deutsch has uploaded a new change for review.

Change subject: ui: Always enable NIC independent fields
......................................................................

ui: Always enable NIC independent fields

Previously the VLANID and Bridge fields in the NIC Details dialog were
disabled soemtimes.
This is now fixed by keeping them enabled all the time.

Change-Id: Ia1c07bb095d48303a6e30405d7ed467aa712f5b5
Signed-off-by: Fabian Deutsch <fabiand at fedoraproject.org>
---
M src/ovirt/node/setup/core/network_page.py
1 file changed, 2 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/06/16506/1

diff --git a/src/ovirt/node/setup/core/network_page.py b/src/ovirt/node/setup/core/network_page.py
index c23527f..1bdb150 100644
--- a/src/ovirt/node/setup/core/network_page.py
+++ b/src/ovirt/node/setup/core/network_page.py
@@ -208,11 +208,9 @@
             elif ipv4_bootproto in ["dhcp"]:
                 for w in nic_ipv4_group:
                     self.widgets[w].enabled(False)
-                    self.widgets["dialog.nic.vlanid"].enabled(True)
             else:
                 for w in nic_ipv4_group:
                     self.widgets[w].enabled(False)
-                    self.widgets["dialog.nic.vlanid"].enabled(True)
             self.widgets["dialog.nic.ipv4.bootproto"].enabled(True)
 
         ipv6_bootproto = helper["dialog.nic.ipv6.bootproto"]
@@ -223,11 +221,9 @@
             elif ipv6_bootproto in ["dhcp"]:
                 for w in nic_ipv6_group:
                     self.widgets[w].enabled(False)
-                    self.widgets["dialog.nic.vlanid"].enabled(True)
             else:
                 for w in nic_ipv6_group:
                     self.widgets[w].enabled(False)
-                    self.widgets["dialog.nic.vlanid"].enabled(True)
             self.widgets["dialog.nic.ipv6.bootproto"].enabled(True)
 
         if "bond.slaves" in changes:
@@ -553,6 +549,8 @@
                         ui.CloseButton("dialog.nic.close", "Close")
                         ]
         self.plugin._nic_details_group.enabled(False)
+        self.plugin.widgets["dialog.nic.vlanid"].enabled(True)
+        self.plugin.widgets["dialog.nic.layout_bridged"].enabled(True)
 
 
 class CreateBondDialog(ui.Dialog):


-- 
To view, visit http://gerrit.ovirt.org/16506
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia1c07bb095d48303a6e30405d7ed467aa712f5b5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>