[node-patches] Change in ovirt-node[master]: valid.FQDN should allow more cases

fabiand at fedoraproject.org fabiand at fedoraproject.org
Tue Jul 9 11:24:24 UTC 2013


Fabian Deutsch has posted comments on this change.

Change subject: valid.FQDN should allow more cases
......................................................................


Patch Set 2: I would prefer that you didn't submit this

I didn't check the patch in detail, but: It would be nice if the examples from the bug could be included in this patch as additional doctests. That way we can prevent regressions in the future (b/c doctests are run at every commit)

-- 
To view, visit http://gerrit.ovirt.org/16592
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacbd4b5358143c0f1be5ed263ad2393283540d33
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the node-patches mailing list