[node-patches] Change in ovirt-node[master]: Fix patch files for the puppet plugin

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: Fix patch files for the puppet plugin
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)

I wonder if we can use the plugin_vars variable instead of carrying a patch a round which needs updates now and then.

Mike, can you say if the plugnis_var is intended for the use case we see here?

....................................................
File ovirt-node.spec.in
Line 184: +            ;;
Line 185: +            puppet_enabled* | puppet_enabled=y | puppet_enabled=1)
Line 186: +            puppet_enabled=1
Line 187: +            ;;
Line 188: +            puppet_server=*)
For these plugin specififc variables, can't plugin_vars (look at ovirt-init-functions.sh.in) be used for this? Maybe Mike can give some input on this.
Line 189: +            puppet_server=${i#puppet_server=}
Line 190: +            ;;
Line 191: +            puppet_certname=*)
Line 192: +            puppet_certname=${i#puppet_certname=}


-- 
To view, visit http://gerrit.ovirt.org/16521
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0938a85d9edf0ab1b672ef973831e9fd3e988403
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>