[node-patches] Change in ovirt-node[master]: Get edit-node to resolve dependencies from repositories on t...

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: Get edit-node to resolve dependencies from repositories on the image
......................................................................


Patch Set 2: Looks good to me, but someone else must approve

(2 inline comments)

....................................................
File tools/edit-node
Line 1272:         cmd = ("python -c \"from yum import YumBase; import re; yb = "
Line 1273:                "YumBase(); print ' '.join(['--enablerepo=%s' % x.id for x in "
Line 1274:                "yb.repos.sort() if not re.match(r'{pat}', x.id)])\"").format(
Line 1275:                    pat=self.repo_pattern)
Line 1276:         print cmd
Where is this print landing?
Line 1277:         f = subprocess.Popen(cmd, shell=True, stdout=PIPE,
Line 1278:                              stderr=STDOUT,
Line 1279:                              preexec_fn=self._chroot)
Line 1280:         output, err = f.communicate()


Line 1286:             os.system("mount -o bind %s %s/tmp/yumrepo/%s" %
Line 1287:                       (pkgs, self._instroot, os.path.basename(pkgs)))
Line 1288:             print os.listdir("%s/tmp/yumrepo" % self._instroot)
Line 1289:             yum_cmd = "yum %s clean all && yum localinstall -y " + \
Line 1290:                       "--setopt=sslverify=false %s /tmp/yumrepo/%s" % \
I wonder if the `--setopt=sslverify=false` should be an option. I can imagine scenarios where we don't want to install the package if the signature is incorrect.

We can probably enable the noverify option in the enable-testing case.
Line 1291:                       (repos, repos, os.path.basename(pkgs))
Line 1292:         else:
Line 1293:             yum_cmd = "yum %s clean all && yum install -y " + \
Line 1294:                       "--setopt=sslverify=false %s %s " % (repos, repos, pkgs)


-- 
To view, visit http://gerrit.ovirt.org/16522
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia16ef06ac763b4cddc8b45dc7b36892147882a6e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>