[node-patches] Change in ovirt-node[master]: throw exception when iscsi initiator name is empty

[Fabian Deutsch]

Fabian Deutsch has posted comments on this change.

Change subject: throw exception when iscsi initiator name is empty
......................................................................


Patch Set 7: (1 inline comment)

....................................................
File src/ovirt/node/setup/core/remote_storage_page.py
Line 46:         model["nfsv4.domain"] = ncfg["domain"]
Line 47:         return model
Line 48: 
Line 49:     def validators(self):
Line 50:         return {"iscsi.initiator_name": valid.IQN(),
Wha is no empty initiator name allowed?
I'd assume that an empty initiator name results in removing all iscsi related stuff
Line 51:                 "nfsv4.domain": (valid.Empty() | valid.FQDN()),
Line 52:                 }
Line 53: 
Line 54:     def ui_content(self):


-- 
To view, visit http://gerrit.ovirt.org/16471
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5e4ac9dd6aa2cc0924281e018b209078f6aba3e
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server