[node-patches] Change in ovirt-node[master]: Get edit-node to resolve dependencies from repositories on t...

[mburns at redhat.com]

Michael Burns has posted comments on this change.

Change subject: Get edit-node to resolve dependencies from repositories on the image
......................................................................


Patch Set 4: I would prefer that you didn't submit this

(1 inline comment)

I think we should review this from an overall design level.

What if we do something like this:

Remove all files from /etc/yum.repos.d
write out the repos.ks repos into a new .repo file
configure them as disabled by default, but enable them automatically in edit-node

....................................................
File tools/edit-node
Line 74:         self.tmpdir = "/var/tmp"
Line 75:         self.dd_dir = None
Line 76:         """The directory in which all temporary files will be created."""
Line 77: 
Line 78:         self.DEVELOPMENT_VERSION = 20
I would much prefer not hard-coding this here.
Line 79:         self.repo_pattern = ""
Line 80: 
Line 81:         self.compress_type = None
Line 82:         """mksquashfs compressor to use. Use 'None' to force reading of the


-- 
To view, visit http://gerrit.ovirt.org/16522
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia16ef06ac763b4cddc8b45dc7b36892147882a6e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>