[node-patches] Change in ovirt-node[master]: ui: Fix kdump page w/ no networking

fabiand at fedoraproject.org fabiand at fedoraproject.org
Wed Jul 10 10:07:04 UTC 2013


Fabian Deutsch has uploaded a new change for review.

Change subject: ui: Fix kdump page w/ no networking
......................................................................

ui: Fix kdump page w/ no networking

Change-Id: I4a630d4d775c3abafb5549a32092890378550655
Signed-off-by: Fabian Deutsch <fabiand at fedoraproject.org>
---
M src/ovirt/node/setup/core/kdump_page.py
1 file changed, 6 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/60/16660/1

diff --git a/src/ovirt/node/setup/core/kdump_page.py b/src/ovirt/node/setup/core/kdump_page.py
index 0e3888a..5552320 100644
--- a/src/ovirt/node/setup/core/kdump_page.py
+++ b/src/ovirt/node/setup/core/kdump_page.py
@@ -94,11 +94,12 @@
                                  "please configure it before NFS " +
                                  "or SSH-based kdump"),
                        ui.Divider("notice.divider")])
+            ws.extend([ui.Options("kdump.type", "Type", self._types)])
 
         else:
             self._types = self._types_local + self._types_remote
-            ws.extend([ui.Options("kdump.type", "Type", self._types),
-                       ui.Divider("divider[0]"),
+            ws.extend([ui.Options("kdump.type", "Type", self._types)])
+            ws.extend([ui.Divider("divider[0]"),
                        ui.Entry("kdump.nfs_location", "NFS Location " +
                                 "(example.com:/var/crash):",
                                 align_vertical=True),
@@ -119,10 +120,11 @@
             net_types = ["kdump.ssh_location", "kdump.nfs_location"]
 
             for w in net_types:
-                self.widgets[w].enabled(False)
+                if w in self.widgets:
+                    self.widgets[w].enabled(False)
 
             w = "kdump.%s_location" % changes["kdump.type"]
-            if w in net_types:
+            if w in net_types and w in self.widgets:
                 self.widgets[w].enabled(True),
                 self.validate({w: ""})
 


-- 
To view, visit http://gerrit.ovirt.org/16660
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4a630d4d775c3abafb5549a32092890378550655
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>



More information about the node-patches mailing list