[node-patches] Change in ovirt-node[master]: Use seperate line to display Rsyslog and Netconsole

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: Use seperate line to display Rsyslog and Netconsole
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File src/ovirt/node/setup/core/status_page.py
Line 198:             destinations.append("Netconsole: %s:%s" %
Line 199:                                 (IPAddress(netconsole["server"]),
Line 200:                                  netconsole["port"] or "6666"))
Line 201: 
Line 202:         return ("\n"+" ".ljust(13)).\
Basically fine, could you just move one part into a var to make it clearer, e.g.:

  indented = "\n" + " ".ljust(13)
  return indented.join(...)
Line 203:             join(destinations) if destinations else "Local Only"
Line 204: 
Line 205: 
Line 206: class HostkeyDialog(ui.Dialog):


-- 
To view, visit http://gerrit.ovirt.org/16794
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic53043ccd106c57ff4ddd95a665fea351e64da7b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: oVirt Jenkins CI Server