[node-patches] Change in ovirt-node[master]: [DRAFT] process: Fix check_output on el6

[fabiand at fedoraproject.org]

Fabian Deutsch has uploaded a new change for review.

Change subject: [DRAFT] process: Fix check_output on el6
......................................................................

[DRAFT] process: Fix check_output on el6

Due to the previous process patch all process related functions expect
lists, but the el6 workaround for check_output passed a string.

Change-Id: I63edf019078e877404d2727b5fd97f24979dbeda
Signed-off-by: Fabian Deutsch <fabiand at fedoraproject.org>
---
M src/ovirt/node/utils/process.py
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/63/16863/1

diff --git a/src/ovirt/node/utils/process.py b/src/ovirt/node/utils/process.py
index 108b3c7..a9eda35 100644
--- a/src/ovirt/node/utils/process.py
+++ b/src/ovirt/node/utils/process.py
@@ -77,8 +77,9 @@
                        encoding=sys.stdin.encoding)
     except AttributeError:
         # We're probably on Python 2.7, which doesn't have check_output
-        if isinstance(args[0], list):
-            args = (" ".join(args[0]),)
+        # http://docs.python.org/2.6/library/subprocess.html#module-subprocess
+        # Working around by using pipe, which doesn't check, but returns the
+        # output
         return pipe(*args, **kwargs)
 
 


-- 
To view, visit http://gerrit.ovirt.org/16863
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I63edf019078e877404d2727b5fd97f24979dbeda
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>