[node-patches] Change in ovirt-node[master]: system: Make which() testable

mburns at redhat.com mburns at redhat.com
Tue Jul 16 13:06:35 UTC 2013


Michael Burns has submitted this change and it was merged.

Change subject: system: Make which() testable
......................................................................


system: Make which() testable

Previously which() used direct FS access, now the File class is used.
Additionally the method was changed to not raise an Exception if a cmd
was not found, instead None is returned.

Change-Id: I37081b4aa34ed3060f1503961d545eb7322bd4b3
Signed-off-by: Fabian Deutsch <fabiand at fedoraproject.org>
---
M src/ovirt/node/utils/fs.py
M src/ovirt/node/utils/system.py
2 files changed, 29 insertions(+), 12 deletions(-)

Approvals:
  Michael Burns: Verified; Looks good to me, approved


-- 
To view, visit http://gerrit.ovirt.org/16860
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I37081b4aa34ed3060f1503961d545eb7322bd4b3
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the node-patches mailing list