[node-patches] Change in ovirt-node[master]: status page: Add confirmation dialog page for "reboot" and "...

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: status page: Add confirmation dialog page for "reboot" and "Power off" buttons
......................................................................


Patch Set 8: I would prefer that you didn't submit this

(1 inline comment)

In general the patch looks good now, except one minor thing- see the inline comment.

....................................................
File src/ovirt/node/ui/__init__.py
Line 779:                          ]
Line 780:         if not buttons:
Line 781:             # Default: OK and Close
Line 782:             self.buttons = [Button(path + ".yes", "OK"),
Line 783:                             CloseButton("dialog.close")]
Please use path + ".close" for the close button,

  CloseButton(path + ".close")

otherwise we maybe can not determin which dialog shall be closed in the on_merge method (as there might be more dialogs with the same button name)
Line 784: 
Line 785: 
Line 786: class TransactionProgressDialog(Dialog):
Line 787:     """Display the progress of a transaction in a dialog


--
To view, visit http://gerrit.ovirt.org/15255
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I56063e812d898e7e7d5490b15e5845115fe45be0
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: oVirt Jenkins CI Server