[node-patches] Change in ovirt-node[master]: security: Migrate password_check

[jboggs at redhat.com]

Joey Boggs has posted comments on this change.

Change subject: security: Migrate password_check
......................................................................


Patch Set 6: Fails

(1 inline comment)

small issue otherwise fine

....................................................
File src/ovirt/node/utils/security.py
Line 72:             message = "You have provided a weak password!\n"
Line 73:             message += "Strong passwords contain a mix of uppercase,\n"
Line 74:             message += "lowercase, numeric and punctuation characters.\n"
Line 75:             message += "They are six or more characters long and\n"
Line 76:             message += "do not contain dictionary words"
not seeing this message returned in the installer or setup for a weak password. Directly calling it via the security module or ovirtfunctions does work though. Otherwise ack
Line 77: 
Line 78:     return message
Line 79: 
Line 80: 


-- 
To view, visit http://gerrit.ovirt.org/15249
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id111da3a61b74213eb8c254de3d8e4d7805bdcc2
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server