[node-patches] Change in ovirt-node[master]: cim_model.py: Miss titles for class "ConfigureCIM" and "SetC...

[jboggs at redhat.com]

Joey Boggs has posted comments on this change.

Change subject: cim_model.py: Miss titles for class "ConfigureCIM" and "SetCIMPassword"
......................................................................


Patch Set 7: I would prefer that you didn't submit this

looks good, might as well change the snmp_keys variable to cim since you touch:         if changes.contains_any(snmp_keys):

lines:
        snmp_keys = ["cim.password_confirmation", "cim.enabled"]

and:
        if changes.contains_any(snmp_keys):

once done ack from me

-- 
To view, visit http://gerrit.ovirt.org/15432
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9660f02ef76f6a44c8c8868a2e5b1abb6f42aaeb
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: oVirt Jenkins CI Server