[node-patches] Change in ovirt-node[master]: [DONTCOMMIT] drop to shell after autoinstall

mburns at redhat.com mburns at redhat.com
Tue Jun 11 14:12:18 UTC 2013


Michael Burns has posted comments on this change.

Change subject: [DONTCOMMIT] drop to shell after autoinstall
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File scripts/ovirt-init-functions.sh.in
Line 1028:     is_auto_install
Line 1029:     auto_install=$?
Line 1030:     if [ "$auto_install" = "0" -o "$stateless" = "0" ]; then
Line 1031:         /usr/libexec/ovirt-auto-install
Line 1032:         bash
if we wrap this in a block like:

if [ OVIRT_TEST_AUTOINSTALL ]; then
  bash
fi

and set TEST_AUTOINSTALL in /etc/default/ovirt, this could be useful longterm...
Line 1033:         rc=$?
Line 1034:         # Handle Log file
Line 1035:         if [ -f $OVIRT_TMP_LOGFILE ]; then
Line 1036:             cat $OVIRT_TMP_LOGFILE >> $OVIRT_LOGFILE


-- 
To view, visit http://gerrit.ovirt.org/15547
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa0ccdf6eb80529992ab3e8b948a30fd9cd4d3b7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the node-patches mailing list