[node-patches] Change in ovirt-node[master]: Make FQDN validator abide by RFC1035

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: Make FQDN validator abide by RFC1035
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

I see that you added a validator for the FQDN length - What do you think about just fixing the existing regular expression? I'm sure there is one which can validate RFC1035.

....................................................
Commit Message
Line 8: 
Line 9: Check for the length of each field as well as the entire
Line 10: hostname to make sure it's not too long
Line 11: 
Line 12: Change-Id: I747a29c1a15b601bf1eea364b76e56818078e80b
Please add the Bug-Url:


-- 
To view, visit http://gerrit.ovirt.org/15583
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I747a29c1a15b601bf1eea364b76e56818078e80b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: oVirt Jenkins CI Server