[node-patches] Change in ovirt-node[master]: add return value when persist command does not return an err...

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: add return value when persist command does not return an error code on failure
......................................................................


Patch Set 7: (1 inline comment)

....................................................
File src/ovirtnode/ovirtfunctions.py
Line 760:     if is_stateless():
Line 761:         return rc
Line 762:     if not os.path.ismount("/config"):
Line 763:         logger.error("/config is not mounted")
Line 764:         rc = 2
Yes, but is that a problem?

My basic assumption is that if something goes wrong a function should return or raise an exception
Line 765:         return rc
Line 766:     if isinstance(files,STRING_TYPE):
Line 767:         files_list = []
Line 768:         files_list.append(files)


-- 
To view, visit http://gerrit.ovirt.org/14737
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I458adeddeb17f63c5d003db808044ad6c8e9e097
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Changming Bai <baichm at linux.vnet.ibm.com>
Gerrit-Reviewer: Changming Bai <baichm at linux.vnet.ibm.com>
Gerrit-Reviewer: Eli Qiao <taget at linux.vnet.ibm.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>
Gerrit-Reviewer: Wenyi Gao <wenyi at linux.vnet.ibm.com>