[node-patches] Change in ovirt-node[master]: edit-node: make a operation option mandatory for using edit-...

[mburns at redhat.com]

Michael Burns has posted comments on this change.

Change subject: edit-node: make a operation option mandatory for using edit-node
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File tools/edit-node
Line 1458:     setup_logging(parser)
Line 1459: 
Line 1460:     (options, args) = parser.parse_args()
Line 1461:     if len(args) != 1:
Line 1462:         parser.print_usage()
should handle this up here so we can print usage.
Line 1463:         sys.exit(1)
Line 1464: 
Line 1465:     print args[0]
Line 1466: 


Line 1502:     # LiveOS set to <LIVEIMG.src>
Line 1503:     (LiveOS, options) = parse_options(sys.argv[1:])
Line 1504:     if not len(sys.argv) > 2:
Line 1505:         print >> sys.stderr, "You must pick an editing option"
Line 1506:         return 1
I don't like the word editing because we have all the non-editing options around printing manifests.

"A manifest or editing option must be specified, use --help for more information"
Line 1507:     if os.geteuid() != 0:
Line 1508:         print >> sys.stderr, "You must run edit-node as root"
Line 1509:         return 1
Line 1510:     if options.name:


-- 
To view, visit http://gerrit.ovirt.org/15398
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I730db91f7953ce9d8ce630183fc0a68c40ed667a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server