[node-patches] Change in ovirt-node[master]: edit-node: remove dd-isoXXX dir during cleanup

[mburns at redhat.com]

Michael Burns has posted comments on this change.

Change subject: edit-node: remove dd-isoXXX dir during cleanup
......................................................................


Patch Set 2: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File tools/edit-node
Line 1224:             # cleanup local repo if exists
Line 1225:             if os.system("umount %s/tmp/yumrepo" % self._instroot):
Line 1226:                 os.system("rm -rf %s/tmp/yumrepo" % self._instroot)
Line 1227:         if os.path.exists(self.dd_dir):
Line 1228:             os.system("umount %s" % self.dd_dir)
We would need to add handling for the case where it doesn't umount.  I'm tempted to ack this, and look for a followup patch to add checking for the result.
Line 1229:             shutil.rmtree(self.dd_dir)
Line 1230:         return
Line 1231: 
Line 1232:     def _run_yum_install(self, pkgs):


-- 
To view, visit http://gerrit.ovirt.org/15400
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If22c7a318109f47d580cffc3c10672a61eaab16e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server