[node-patches] Change in ovirt-node[master]: scripts: Replace ovirt-config-password tool

[mburns at redhat.com]

Michael Burns has posted comments on this change.

Change subject: scripts: Replace ovirt-config-password tool
......................................................................


Patch Set 11: I would prefer that you didn't submit this

(1 inline comment)

haven't tested yet, but fails pep8

....................................................
File src/ovirt/node/utils/network.py
Line 50:     _nm_client = NMClient.Client.new()
Line 51:     LOGGER.debug("NetworkManager support via GI (fast-path)")
Line 52: except Exception as e:
Line 53:     LOGGER.debug("NetworkManager support disabled: " +
Line 54:                 "NM Client not found (%s)" % e)
space indent error causes failed pep8
Line 55: 
Line 56: 
Line 57: class UnknownNicError(Exception):
Line 58:     pass


-- 
To view, visit http://gerrit.ovirt.org/15250
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7acf7fe4782fb7cee3d493e3eb26f7c6230491d8
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server