[node-patches] Change in ovirt-node[master]: CreateBondDialog: Using button "Close" instead of "Reset"

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: CreateBondDialog: Using button "Close" instead of "Reset"
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

Basically fine, I'd just move it into a different class.

....................................................
File src/ovirt/node/setup/core/network_page.py
Line 564:                    NicTable("bond.slaves", multi=True)]
Line 565:         super(CreateBondDialog, self).__init__(path, "Create Bond", widgets)
Line 566:         self.buttons = [ui.SaveButton("bond.save", "Save"),
Line 567:                         ui.CloseButton("bond.close", "Close")
Line 568:                         ]
We should probably move this to the Dialog class.
But it has to be taken care that no other dialog breaks.


-- 
To view, visit http://gerrit.ovirt.org/16022
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifea2929a328da50493f5336d389b07202ac755b1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: oVirt Jenkins CI Server