[node-patches] Change in ovirt-node[master]: ui: Remove irritating text before opening dialogs

fabiand at fedoraproject.org fabiand at fedoraproject.org
Mon Jun 24 08:44:07 UTC 2013


Fabian Deutsch has uploaded a new change for review.

Change subject: ui: Remove irritating text before opening dialogs
......................................................................

ui: Remove irritating text before opening dialogs

In the days of using less to display text on the screen we told the user
about pressing 'q' to quit. Now, in the days of using real dialogs, this
message (Press 'ESC' to quit) seems to be irritating, at first because
it's not shown within the dialog, but on e the page before, and second,
because there is already a close button on the dialog itself (in
addition to using ESC to close a dialog).

Change-Id: I8b264e02af8ea7ada10ac8f8d272763369b078bb
Signed-off-by: Fabian Deutsch <fabiand at fedoraproject.org>
---
M src/ovirt/node/setup/core/diagnostics_page.py
M src/ovirt/node/setup/core/support_page.py
2 files changed, 2 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/26/16026/1

diff --git a/src/ovirt/node/setup/core/diagnostics_page.py b/src/ovirt/node/setup/core/diagnostics_page.py
index afa19ee..d1da5f4 100644
--- a/src/ovirt/node/setup/core/diagnostics_page.py
+++ b/src/ovirt/node/setup/core/diagnostics_page.py
@@ -49,8 +49,7 @@
         This is an ordered list of (path, widget) tuples.
         """
         ws = [ui.Header("diagnostic._header", "Diagnostic Utilities"),
-              ui.Label("diagnostic.info", "Select one of the tools below. \n" +
-                       "Press '<ESC>' to quit when viewing output"),
+              ui.Label("diagnostic.info", "Select one of the tools below."),
               ui.Divider("diagnostic.divider"),
               ui.Table("diagnostic.tools", "", "Available diagnostics",
                        self.__diagnostics(), height=min(
diff --git a/src/ovirt/node/setup/core/support_page.py b/src/ovirt/node/setup/core/support_page.py
index d847b1f..718bdac 100644
--- a/src/ovirt/node/setup/core/support_page.py
+++ b/src/ovirt/node/setup/core/support_page.py
@@ -45,8 +45,7 @@
 
     def ui_content(self):
         ws = [ui.Header("header[0]", "Support Info"),
-              ui.Label("support.info", "Select one of the logfiles below. \n" +
-                       "Press '<ESC>' to quit when viewing a logfile."),
+              ui.Label("support.info", "Select one of the logfiles below."),
               ui.Divider("divider[0]"),
               ui.Table("support.logfile", "", "Available Logfiles",
                        self.__debugfiles_to_offer()),


-- 
To view, visit http://gerrit.ovirt.org/16026
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8b264e02af8ea7ada10ac8f8d272763369b078bb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>



More information about the node-patches mailing list