[node-patches] Change in ovirt-node[master]: edit-node: shown correct info for files ovirt-node-plugin-xx...

[jboggs at redhat.com]

Joey Boggs has posted comments on this change.

Change subject: edit-node: shown correct info for files ovirt-node-plugin-xxx and delta-manifest-rpm/srpm/file.txt
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File tools/edit-node
Line 827:             # if current-XXX-manifest exists run delta based on it
Line 828:             if os.path.exists("%s/iso/isolinux/current-manifest-%s.txt"
Line 829:                               % (self._ImageCreator__builddir, i)):
Line 830:                 cmd = "cp %s/iso/isolinux/current-manifest-%s.txt %s/" \
Line 831:                       "current-manifest-%s.txt" \
not necessary to add "current-" to all these manifest outputs otherwise the directory structure ends up with duplicates:

isolinux/update1/manifest-XXXXX
isolinux/update1/current-manifest-XXXXX

otherwise ack
Line 832:                     % (self._ImageCreator__builddir,
Line 833:                        i,
Line 834:                        self._instroot,
Line 835:                        i)


-- 
To view, visit http://gerrit.ovirt.org/15990
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b23ef7bd3dd0af29ed4e39f02a614571edf3039
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: Joey Boggs <jboggs at redhat.com>