[node-patches] Change in ovirt-node[master]: synchronize log dir with iso on boot

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: synchronize log dir with iso on boot
......................................................................


Patch Set 7: (1 inline comment)

....................................................
File src/ovirtnode/ovirtfunctions.py
Line 1789: # should only be used when syncing a directory structure from iso
Line 1790: # to disk like /var/log
Line 1791: # use case -- upgrade adds some service which logs to /var/log/<service>
Line 1792: # need to have the directory created, but it's not on iso upgrade
Line 1793: def copy_dir_if_not_exist(orig, target):
the python way for such comments as above is:
def func():
   """first line
   more lines with documentation
   """
   (body)
Line 1794:   for f in os.listdir(orig):
Line 1795:     if os.path.isdir("%s/%s" % (orig, f)):
Line 1796:         if not os.path.exists("%s/%s" % (target, f)):
Line 1797:             system_closefds("cp -av %s/%s %s &>/dev/null" % (orig, f, target))


-- 
To view, visit http://gerrit.ovirt.org/15018
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife2399c9cb1fb7eb9fd572f9214ee74f8a61a8ce
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Michael Burns <mburns at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>