[node-patches] Change in ovirt-node[master]: Workaround missing subprocess.check_output on Python 2.6

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: Workaround missing subprocess.check_output on Python 2.6
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File src/ovirt/node/utils/process.py
Line 72:     """subprocess.check_output wrapper to not leak file descriptors
Line 73:     """
Line 74:     kwargs = __update_kwargs(kwargs)
Line 75:     LOGGER.debug("Checking output with: %s %s" % (args, kwargs))
Line 76:     if sys.version_info[:2] == (2, 6):
could we puill this logic into a separate function e.g.
system.is_python_2.6()
Line 77:         #No subprocess.check_output
Line 78:         return pipe(*args)
Line 79:     return unicode(subprocess.check_output(*args, **kwargs),
Line 80:                    encoding=sys.stdin.encoding)


-- 
To view, visit http://gerrit.ovirt.org/16049
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia201854707fd1300766488d8094585b90b868b3c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>