[node-patches] Change in ovirt-node[master]: utils: Fix subprocess.check

fabiand at fedoraproject.org fabiand at fedoraproject.org
Tue Jun 25 11:45:00 UTC 2013


Fabian Deutsch has uploaded a new change for review.

Change subject: utils: Fix subprocess.check
......................................................................

utils: Fix subprocess.check

The python_26 call was use dincorrectly and always returned True
(because the existance of the function was checked, becauuse the () were
missed).

Change-Id: Ic980f637a689610c498a883fc2ea11260c48e7ee
Signed-off-by: Fabian Deutsch <fabiand at fedoraproject.org>
---
M src/ovirt/node/utils/process.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/71/16071/1

diff --git a/src/ovirt/node/utils/process.py b/src/ovirt/node/utils/process.py
index b0bbfa7..2f0cb17 100644
--- a/src/ovirt/node/utils/process.py
+++ b/src/ovirt/node/utils/process.py
@@ -74,7 +74,7 @@
     """
     kwargs = __update_kwargs(kwargs)
     LOGGER.debug("Checking output with: %s %s" % (args, kwargs))
-    if ovirt.node.utils.system.is_python_2_6:
+    if ovirt.node.utils.system.is_python_2_6():
         return pipe(*args)
     return unicode(subprocess.check_output(*args, **kwargs),
                    encoding=sys.stdin.encoding)


-- 
To view, visit http://gerrit.ovirt.org/16071
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic980f637a689610c498a883fc2ea11260c48e7ee
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>



More information about the node-patches mailing list