[node-patches] Change in ovirt-node[master]: fix plugin kargs sorting to defaults file

[mburns at redhat.com]

Michael Burns has posted comments on this change.

Change subject: fix plugin kargs sorting to defaults file
......................................................................


Patch Set 1: (1 inline comment)

Took me a bit to see what this is doing.  We're processing the variable, but never actually setting it to the value set in the cmdline.  

ACK on the change, but one nitpick

....................................................
File scripts/ovirt-init-functions.sh.in
Line 731:                 bootparams="$bootparams $i"
Line 732:             else
Line 733:                 i=${i#$varname=}
Line 734:                 var=$(eval echo $varname)
Line 735:                 eval $var=$i
Why not this?

i=${i#$varname=}
eval $varname=$i
Line 736:                 plugin_vars="$plugin_vars $varname"
Line 737:             fi
Line 738:             ;;
Line 739:         esac


-- 
To view, visit http://gerrit.ovirt.org/16053
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I381f96f46cffd2babff78089b59862eb8a71d2ed
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>