[node-patches] Change in ovirt-node[master]: ui: Fix ConfirmedEntry building

fabiand at fedoraproject.org fabiand at fedoraproject.org
Tue Jun 25 12:22:50 UTC 2013


Fabian Deutsch has uploaded a new change for review.

Change subject: ui: Fix ConfirmedEntry building
......................................................................

ui: Fix ConfirmedEntry building

Due to testing a wrog patch was posted previously, this patch now adds
(uncomments) the relevant sections which were missed in a previous
patch.

Change-Id: Ic19603f226c6be9ee714373defa6964691d2cdc9
Signed-off-by: Fabian Deutsch <fabiand at fedoraproject.org>
---
M src/ovirt/node/ui/urwid_builder.py
1 file changed, 7 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/74/16074/1

diff --git a/src/ovirt/node/ui/urwid_builder.py b/src/ovirt/node/ui/urwid_builder.py
index e49051f..e697996 100644
--- a/src/ovirt/node/ui/urwid_builder.py
+++ b/src/ovirt/node/ui/urwid_builder.py
@@ -36,11 +36,13 @@
 
         for element in ui_container.children:
             widget = self.build(element)
-            #if type(ui_container) is ui.ConfirmedEntry:
-            #    # Special handling of the special widget, but why?
-            #    widgets.append(widget)
-            #else:
-            widgets.append(("pack", widget))
+            if type(ui_container) is ui.ConfirmedEntry:
+                # Special handling of the special widget, but why?
+                # Why? Because nested Pile's need to be taken care of.
+                # FIXME Generalize this (to cover other widgets too)
+                widgets.append(widget)
+            else:
+                widgets.append(("pack", widget))
 
         # Add buttons
         if hasattr(ui_container, "buttons") and ui_container.buttons:


-- 
To view, visit http://gerrit.ovirt.org/16074
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic19603f226c6be9ee714373defa6964691d2cdc9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>



More information about the node-patches mailing list