[node-patches] Change in ovirt-node[master]: fix spec file bug

mburns at redhat.com mburns at redhat.com
Wed Jun 26 15:21:45 UTC 2013


Michael Burns has uploaded a new change for review.

Change subject: fix spec file bug
......................................................................

fix spec file bug

When a spec variable is not defined, we need %{?var}.
The ? was missing in some cases.  If it's missing and var is not
defined, then %{var} resolves to %{var} which fails integer
comparisons

Change-Id: I19507f7687645bcc68ddabd2a29a4f1026c01955
Signed-off-by: Mike Burns <mburns at redhat.com>
---
M ovirt-node.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/24/16124/1

diff --git a/ovirt-node.spec.in b/ovirt-node.spec.in
index 441bb4e..d15ffe4 100644
--- a/ovirt-node.spec.in
+++ b/ovirt-node.spec.in
@@ -8,7 +8,7 @@
 %define is_centos_systemd %(test 0%{?centos} -ne 0 && test %{?centos} -ge 7 && echo 1 || echo 0)
 %define is_systemd %( test %{is_rhel_systemd} -eq 1 || test %{is_centos_systemd} = 1 || test %{is_fedora_systemd} = 1 && echo 1 || echo 0)
 %define dracutdir %(test -e /usr/share/dracut && echo "/usr/share/dracut/modules.d" || echo "/usr/lib/dracut/modules.d")
-%define is_el6 %(test 0%{centos} -eq 06 || test 0%{rhel} -eq 06 && echo 1 || echo 0)
+%define is_el6 %(test 0%{?centos} -eq 06 || test 0%{?rhel} -eq 06 && echo 1 || echo 0)
 
 
 Summary:        The %{product_family} daemons/scripts


-- 
To view, visit http://gerrit.ovirt.org/16124
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I19507f7687645bcc68ddabd2a29a4f1026c01955
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Michael Burns <mburns at redhat.com>



More information about the node-patches mailing list