[node-patches] Change in ovirt-node[master]: ovirt-node-upgrade: add lock file check to prevent parallel ...

[jboggs at redhat.com]

Joey Boggs has posted comments on this change.

Change subject: ovirt-node-upgrade: add lock file check to prevent parallel runs
......................................................................


Patch Set 3:

redid the locking much more simple. If another instance is running the following is shown. Incase the lockfile is leftover somehow if the pid is dead it will start a new instance.

ovirt-node-upgrade.UpgradeTool: INFO     Temporary Directory is: /data/tmppKrOoL
ovirt-node-upgrade.LockFile: INFO     Acquiring Lock
Traceback (most recent call last):
  File "/tmp/ovirt-node-upgrade.py", line 348, in <module>
    u.run()
  File "/tmp/ovirt-node-upgrade.py", line 308, in run
    self.lock._acquire()
  File "/tmp/ovirt-node-upgrade.py", line 87, in _acquire
    raise RuntimeError("You already have an instance of the program running")
RuntimeError: You already have an instance of the program running

-- 
To view, visit http://gerrit.ovirt.org/14960
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifdd6553046d99cf9c9db29c1c899dc93e8ad733a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>