[node-patches] Change in ovirt-node[master]: performance_page.py: Using button "Reload" instead of "Reset...

[mburns at redhat.com]

Michael Burns has posted comments on this change.

Change subject: performance_page.py: Using button "Reload" instead of "Reset"
......................................................................


Patch Set 3: Fails; I would prefer that you didn't submit this

(1 inline comment)

The issue with Current Active profile not updating is fixed in another patch.

There is currently no Reload button in the infrastructure.

We can drop Reset or even create the Reset button and change the label to Reload.  They accomplish the same function.

....................................................
File src/ovirt/node/setup/core/performance_page.py
Line 60:               ]
Line 61:         page = ui.Page("page", ws)
Line 62:         self.widgets.add(page)
Line 63:         page.buttons = [ui.SaveButton("page.save"),
Line 64:                         ui.ReloadButton("page.reload")]
There is no Reload Button defined.  Reset does the same thing as you're trying to accomplish here, I think
Line 65:         return page
Line 66: 
Line 67:     def on_change(self, changes):
Line 68:         pass


-- 
To view, visit http://gerrit.ovirt.org/16173
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9870e17a098de4045fbdb75c8b02e5cc0f594816
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server