[node-patches] Change in ovirt-node[master]: performance_page.py: Drop "Reset" button

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: performance_page.py: Drop "Reset" button
......................................................................


Patch Set 4: I would prefer that you didn't submit this

(3 inline comments)

Basically fine, just one nitpick.

....................................................
File src/ovirt/node/setup/core/diagnostics_page.py
Line 57:               ]
Line 58: 
Line 59:         page = ui.Page("page", ws)
Line 60:         self.widgets.add(page)
Line 61:         page.buttons = []
Please put the page.buttons = [] before the self.widgets.add(page) line
Line 62:         return page
Line 63: 
Line 64:     def on_change(self, changes):
Line 65:         pass


....................................................
File src/ovirt/node/setup/core/keyboard_page.py
Line 56:               ]
Line 57: 
Line 58:         page = ui.Page("page", ws)
Line 59:         self.widgets.add(page)
Line 60:         page.buttons = [ui.SaveButton("page.save")]
Please put the page.buttons = [...] before the self.widgets.add(page) line
Line 61:         return page
Line 62: 
Line 63:     def on_change(self, changes):
Line 64:         pass


....................................................
File src/ovirt/node/setup/core/performance_page.py
Line 59:                        profiles),
Line 60:               ]
Line 61:         page = ui.Page("page", ws)
Line 62:         self.widgets.add(page)
Line 63:         page.buttons = [ui.SaveButton("page.save")]
Please put the page.buttons = [...] before the self.widgets.add(page) line
Line 64:         return page
Line 65: 
Line 66:     def on_change(self, changes):
Line 67:         pass


-- 
To view, visit http://gerrit.ovirt.org/16173
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9870e17a098de4045fbdb75c8b02e5cc0f594816
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>
Gerrit-Reviewer: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: oVirt Jenkins CI Server