[node-patches] Change in ovirt-node[master]: Stop doing circular imports in process.check_output

[mburns at redhat.com]

Michael Burns has posted comments on this change.

Change subject: Stop doing circular imports in process.check_output
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File src/ovirt/node/utils/process.py
Line 18: # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
Line 19: # MA  02110-1301, USA.  A copy of the GNU General Public License is
Line 20: # also available at http://www.gnu.org/copyleft/gpl.html.
Line 21: from subprocess import STDOUT, PIPE
Line 22: import logging
maybe just do:

from ovirt.node.utils.system import is_python_2_6
Line 23: import subprocess
Line 24: import sys
Line 25: 
Line 26: """


Line 73:     """
Line 74:     import ovirt.node.utils.system
Line 75:     kwargs = __update_kwargs(kwargs)
Line 76:     LOGGER.debug("Checking output with: %s %s" % (args, kwargs))
Line 77:     if ovirt.node.utils.system.is_python_2_6():
and run is_python_2_6() here
Line 78:         return pipe(*args)
Line 79:     return unicode(subprocess.check_output(*args, **kwargs),
Line 80:                    encoding=sys.stdin.encoding)
Line 81: 


-- 
To view, visit http://gerrit.ovirt.org/16211
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic779d49b0c1e46f416a5c62fc707a10bb5fb9baf
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server