[node-patches] Change in ovirt-node[master]: /dev/live doesn't exist on F17 or F18. Use /dev/initramfs/li...

[mburns at redhat.com]

Michael Burns has posted comments on this change.

Change subject: /dev/live doesn't exist on F17 or F18. Use /dev/initramfs/livedev
......................................................................


Patch Set 4: I would prefer that you didn't submit this

(2 inline comments)

....................................................
Commit Message
Line 7: /dev/live doesn't exist on F17 or F18. Use /dev/initramfs/livedev
Line 8: 
Line 9: mount_live() attempts to mount /dev/live to get version info.
Line 10: /dev/live has not existed since the end of the F16 lifecycle. Use
Line 11: /dev/initramfs/livedev instead.
Needs updating.  We're not using livedev, we're basing off what is mounted on /dev/.initramfs/live
Line 12: 
Line 13: Change-Id: I6cee5e5dfe70f38f06bda24066c757872289430d
Line 14: Bug-Url:  https://bugzilla.redhat.com/show_bug.cgi?id=740280


....................................................
File src/ovirtnode/ovirtfunctions.py
Line 63: PRODUCT_VERSION = aug.get("/files/etc/default/version/VERSION")
Line 64: PRODUCT_RELEASE = aug.get("/files/etc/default/version/RELEASE")
Line 65: 
Line 66: DEV_LIVE = "/dev/{live}".format(live=process.check_output(
Line 67:                                 "/usr/libexec/ovirt-functions get_live_disk")
get_live_disk is in ovirt-boot-functions, not in ovirt-functions
Line 68:                                 .strip())
Line 69: 
Line 70: OVIRT_VARS = {}
Line 71: # Parse all OVIRT_* variables


-- 
To view, visit http://gerrit.ovirt.org/16208
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6cee5e5dfe70f38f06bda24066c757872289430d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>