[node-patches] Change in ovirt-node[master]: [RFE] show available space for data instead of -1

[mburns at redhat.com]

Michael Burns has posted comments on this change.

Change subject: [RFE] show available space for data instead of -1
......................................................................


Patch Set 1: I would prefer that you didn't submit this

This seems like it could cause some issues.  I'd rather do this in the screen logic than in backend storage logic

Standard flow:

User get's to this screen, sees the values, but says "i want a bigger swap" so they increase it.  The value of Data doesn't decrease.  

What about doing something like this:

* Add a field on the screen that has "Currently Unused Space"
* This field gets updated dynamically when changing other fields
* Have some keyword or special logic around the Data partition size so that if it's set to "MAX"(case insensitive) "-1" or blank, it will default to -1 in backend logic.


Another approach could be:

Add a checkbox for "Fill disk with Data partition"
If that is set, disable the Data field from being edited
have the screen update the data field based on the values of the other fields


In all cases, make sure that if the sum of all fields is > total size, that we don't allow the installer to proceed.

-- 
To view, visit http://gerrit.ovirt.org/16051
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3854b4d3469d2e0f2033e99d548f0e16c3f040a6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>