[node-patches] Change in ovirt-node[master]: tuned.py: Catch the AttributeError when set the active tuned...

mburns at redhat.com mburns at redhat.com
Fri Jun 28 14:22:00 UTC 2013


Michael Burns has posted comments on this change.

Change subject: tuned.py: Catch the AttributeError when set the active tuned profile as "None"
......................................................................


Patch Set 2: I would prefer that you didn't submit this

Do we really need this?  I can't reproduce the initial error reported.  

Also, we need to catch more generic errors than AttributeError.  on Fedora, tuned-adm returns an error status if the profile is None or off.  This doesn't get caught with the current patch.

-- 
To view, visit http://gerrit.ovirt.org/16128
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieebaa1a6e304ab6c39edd788aaf7c9278e31e24a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the node-patches mailing list