[node-patches] Change in ovirt-node[master]: storage: Don't run device discovery in new thread

fabiand at fedoraproject.org fabiand at fedoraproject.org
Tue Mar 5 16:15:44 UTC 2013


Fabian Deutsch has uploaded a new change for review.

Change subject: storage: Don't run device discovery in new thread
......................................................................

storage: Don't run device discovery in new thread

DeviceDiscovery can not be run in another thread, because the main
thread and the discovery thread both access ovirtnpode.ovirtfunctions,
which uses module-wide variables which aren't threadsafe (aug/augeas).

Change-Id: Idc369e43e60edd64dd0448847589b9943fdd9496
Signed-off-by: Fabian Deutsch <fabiand at fedoraproject.org>
---
M scripts/tui/src/ovirt/node/installer/boot_device_page.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/34/12734/1

diff --git a/scripts/tui/src/ovirt/node/installer/boot_device_page.py b/scripts/tui/src/ovirt/node/installer/boot_device_page.py
index 6229538..cc05014 100644
--- a/scripts/tui/src/ovirt/node/installer/boot_device_page.py
+++ b/scripts/tui/src/ovirt/node/installer/boot_device_page.py
@@ -32,7 +32,7 @@
     def __init__(self, app):
         super(Plugin, self).__init__(app)
         self.storage_discovery = StorageDiscovery(app.args.dry)
-        self.storage_discovery.start()
+        self.storage_discovery.run()
 
     def name(self):
         return "Boot Device"


--
To view, visit http://gerrit.ovirt.org/12734
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idc369e43e60edd64dd0448847589b9943fdd9496
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>



More information about the node-patches mailing list