[node-patches] Change in ovirt-node[master]: installer: Don't reload, just re-parse

[fabiand at fedoraproject.org]

Fabian Deutsch has uploaded a new change for review.

Change subject: installer: Don't reload, just re-parse
......................................................................

installer: Don't reload, just re-parse

Previously ovirtnode.ovirtfunctions were used by the main thread (running
the UI) and the installer thread (which is a different thread
running in the backgrouund to keep the ui respsonsive). This lead to
problems with th eaug variable in ovirtfunctions. To work around this
problem, the installer thread is now only explicitly using
parse_defaults to re-parse the defaults file, instead of reloading the
whole ovirtfunctions module.

Change-Id: I368b6cf56e0ede48b6a564ed4cea274a9198a858
Signed-off-by: Fabian Deutsch <fabiand at fedoraproject.org>
---
M scripts/tui/src/ovirt/node/installer/progress_page.py
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/59/12759/1

diff --git a/scripts/tui/src/ovirt/node/installer/progress_page.py b/scripts/tui/src/ovirt/node/installer/progress_page.py
index 64635cd..93141a9 100644
--- a/scripts/tui/src/ovirt/node/installer/progress_page.py
+++ b/scripts/tui/src/ovirt/node/installer/progress_page.py
@@ -209,8 +209,8 @@
 
         def commit(self):
             from ovirtnode import storage
-            # Reload is needed to re-read defaults file ..
-            reload(storage._functions)
+            # Re-read defaults file to pick up changes
+            storage._functions.parse_defaults()
             config_storage = storage.Storage()
             storage_setup = config_storage.perform_partitioning()
             if not storage_setup:


--
To view, visit http://gerrit.ovirt.org/12759
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I368b6cf56e0ede48b6a564ed4cea274a9198a858
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>