[node-patches] Change in ovirt-node[master]: edit-node: fix iso file name from stripping characters

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: edit-node: fix iso file name from stripping characters
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File tools/edit-node
Line 1514:                 if len(n) > 0:
Line 1515:                     n = n + "."
Line 1516:                 rel_tag=LiveOS.strip(".iso").split(".")[-1]
Line 1517:                 finished_iso = "%s.%s%s.iso" % \
Line 1518:                     (edited_iso.rstrip("%s.edited.iso" %rel_tag), n.replace(" ","-"), rel_tag)
I'd rather use replace instead of rstrip, as rstrip is taking a string (list) of chars that will be replaced on the right side.
Line 1519:                 shutil.move(edited_iso, finished_iso)
Line 1520: 
Line 1521:                 logging.info("%s.iso saved to %s"  % (editor.name, finished_iso))
Line 1522:             else:


--
To view, visit http://gerrit.ovirt.org/13153
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id229579f5717529924abb1ce913f1cc3b045ad39
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>