[node-patches] Change in ovirt-node[master]: build: Remove top-level check target

fabiand at fedoraproject.org fabiand at fedoraproject.org
Wed May 15 13:08:30 UTC 2013


Fabian Deutsch has uploaded a new change for review.

Change subject: build: Remove top-level check target
......................................................................

build: Remove top-level check target

The logic is now kept in the src/ subdir.

Change-Id: I474c87aa93f7d48b496c77877eb53f4454e070a2
Signed-off-by: Fabian Deutsch <fabiand at fedoraproject.org>
---
M Makefile.am
1 file changed, 4 insertions(+), 40 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/45/14745/1

diff --git a/Makefile.am b/Makefile.am
index c86c962..e24b70e 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -74,46 +74,10 @@
 .PHONY: rpms publish srpms
 
 
-check-local: doctests pep8 pyflakes pylint
-	@echo -e "---\n Passed.\n---"
+check-local: static-checks
+	@echo Passed $@
 
-check-local-fast:
-	@for M in $(PYTHONSOURCES); \
-	do \
-		export PARENT=$$$$ ; \
-		echo "Fast checks on '$$M'"; \
-		PYTHONPATH=. python -m doctest $$M || kill $$PARENT & \
-		PYTHONPATH=. pep8 -r $$M || kill $$PARENT & \
-		PYTHONPATH=. pyflakes $$M || kill $$PARENT & \
-	done ; wait
-
-doctests:
-	@for M in $(PYTHONSOURCES); \
-	do \
-		echo Doctest on "$$M"; \
-		PYTHONPATH=. python -m doctest $$M || exit 1; \
-	done
-
-pep8:
-	@for M in $(PYTHONSOURCES); \
-	do \
-		echo pep8 on "$$M"; \
-		PYTHONPATH=. pep8 -r $$M || exit 1; \
-	done
-
-PYLINT=pylint -f parseable --include-ids=yes --rcfile=.pylintrc
-pylint:
-	@for M in $(PYTHONSOURCES); \
-	do \
-		echo pylint on "$$M"; \
-		PYTHONPATH=. $(PYLINT) $$M || exit 1; \
-	done
-
-pyflakes:
-	@for M in $(PYTHONSOURCES); \
-	do \
-		echo pyflakes on "$$M"; \
-		PYTHONPATH=. pyflakes $$M || exit 1; \
-	done
+static-checks:
+	$(MAKE) -C src check-local
 
 # vim: ts=2


--
To view, visit http://gerrit.ovirt.org/14745
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I474c87aa93f7d48b496c77877eb53f4454e070a2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>



More information about the node-patches mailing list