[node-patches] Change in ovirt-node[master]: update cpu_details to read full topology

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: update cpu_details to read full topology
......................................................................


Patch Set 2: Looks good to me, but someone else must approve

(2 inline comments)

....................................................
File src/ovirtnode/ovirtfunctions.py
Line 1563:         siblingsIds = []
Line 1564: 
Line 1565:         socketIds = [proc.getAttribute('socket_id')
Line 1566:                      for proc in cells.getElementsByTagName('cpu')
Line 1567:                      if proc.getAttribute('socket_id') not in socketIds ]
I missed this - but there also shouldn't be any traling whitespaces after the last char and the closing bracket.
Line 1568: 
Line 1569:         siblingsIds = [proc.getAttribute('siblings')
Line 1570:                        for proc in cells.getElementsByTagName('cpu')
Line 1571:                        if proc.getAttribute('siblings') not in siblingsIds ]


Line 1567:                      if proc.getAttribute('socket_id') not in socketIds ]
Line 1568: 
Line 1569:         siblingsIds = [proc.getAttribute('siblings')
Line 1570:                        for proc in cells.getElementsByTagName('cpu')
Line 1571:                        if proc.getAttribute('siblings') not in siblingsIds ]
same as above
Line 1572:         cpu_topology = "OK"
Line 1573:     except:
Line 1574:         cpu_topology = "Unknown"
Line 1575:     status_msg += "CPU Name: %s\n" % cpu_dict["model name"].replace("  "," ")


--
To view, visit http://gerrit.ovirt.org/14748
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2cb086e119b4f5c5d430072883532c404a3bb652
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Michael Burns <mburns at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>