[node-patches] Change in ovirt-node[master]: add return value when persist command does not return an err...

[mburns at redhat.com]

Michael Burns has posted comments on this change.

Change subject: add return value when persist command does not return an error code on failure
......................................................................


Patch Set 2:

Overall, this is a good, change, but a couple notes:

1.  You should be using the python based ovirt_store_config from src/ovirtnode/ovirtfunctions.py
2.  The change should be consistent between the python and bash versions, so we need to add some sort of return code there
3.  We should make an equivalent change in ovirt_store_config_atomic as well, if it's necessary.

--
To view, visit http://gerrit.ovirt.org/14737
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I458adeddeb17f63c5d003db808044ad6c8e9e097
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Changming Bai <baichm at linux.vnet.ibm.com>
Gerrit-Reviewer: Changming Bai <baichm at linux.vnet.ibm.com>
Gerrit-Reviewer: Eli Qiao <taget at linux.vnet.ibm.com>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>
Gerrit-Reviewer: Wenyi Gao <wenyi at linux.vnet.ibm.com>