[node-patches] Change in ovirt-node[master]: RFC: Use optparse when in argparse isn't available

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: RFC:  Use optparse when in argparse isn't available
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File src/ovirt/node/app.py
Line 125:         self.ui = self.ui_builder.build(ui.Window("screen", self))
Line 126:         self.plugin_base = plugin_base
Line 127: 
Line 128:     def __parse_cmdline(self):
Line 129:         try:
I wonder if we should drop support for argparse, as optparse gives us all we need, doesn't it?
Line 130:             import argparse
Line 131:             parser = argparse.ArgumentParser(description='oVirt Node Utility')
Line 132:             parser.add_argument("--defaults",
Line 133:                                 type=str,


--
To view, visit http://gerrit.ovirt.org/14857
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id9fdc1062f0dfbb1f7c8807981acdbf3fd805792
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Michael Burns <mburns at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>