[node-patches] Change in ovirt-node[master]: setup: Use TextViewDialog in support page

fabiand at fedoraproject.org fabiand at fedoraproject.org
Tue May 21 12:19:47 UTC 2013


Fabian Deutsch has uploaded a new change for review.

Change subject: setup: Use TextViewDialog in support page
......................................................................

setup: Use TextViewDialog in support page

Previously the UI was hidden and less was used to display long files,
now the 'native' TextViewDialog is used instead.

Change-Id: Icab066cddedfbb3652e77b91c13181cba7c2c1fb
Signed-off-by: Fabian Deutsch <fabiand at fedoraproject.org>
---
M src/ovirt/node/setup/support_page.py
1 file changed, 4 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/30/14930/1

diff --git a/src/ovirt/node/setup/support_page.py b/src/ovirt/node/setup/support_page.py
index 4e1abf9..6c18ffd 100644
--- a/src/ovirt/node/setup/support_page.py
+++ b/src/ovirt/node/setup/support_page.py
@@ -20,6 +20,7 @@
 # also available at http://www.gnu.org/copyleft/gpl.html.
 from ovirt.node import ui, utils
 from ovirt.node.plugins import NodePlugin
+from ovirt.node.utils import process
 
 """
 A plugin for a support page
@@ -79,9 +80,9 @@
             cmd = cmds[logfile] if logfile in cmds else None
 
             if cmd:
-                with self.application.ui.suspended():
-                    utils.process.call("reset")
-                    utils.process.call(cmd)
+                contents = process.check_output(cmd, stderr=process.STDOUT)
+                return ui.TextViewDialog("output.dialog", "Logfile",
+                                         contents)
 
     def __debugfiles_to_offer(self):
         return [("node", "/var/log/ovirt.log"),


--
To view, visit http://gerrit.ovirt.org/14930
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icab066cddedfbb3652e77b91c13181cba7c2c1fb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>



More information about the node-patches mailing list