[node-patches] Change in ovirt-node[master]: Update reboot task to run async from installer and install m...

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: Update reboot task to run async from installer and install module
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File src/ovirt/node/utils/system.py
Line 38:     """
Line 39:     reboot_task = DelayedReboot()
Line 40:     try:
Line 41:         import daemon
Line 42:         reboot_task.delayed_reboot(5)
I can't find the delayed_reboot function in DelayedReboot.

Further more I'd prefer to add a new function e.g. def async_reboot(delay=5) which can be used to spawn an async reboot (which is what DelayedReboot does) instead of changing the current reboots behavior. It might be that some component is expecting the current reboot function to block.

As in the example above I'd make the delay configurable/a param and set it to a reasonable default, like 5
Line 43:     except:
Line 44:         reboot_task.reboot(5)
Line 45: 
Line 46: def poweroff():


--
To view, visit http://gerrit.ovirt.org/14491
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1b4e048ff56b8c9ebd49a82b3d5546c7c326df8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Joey Boggs <jboggs at redhat.com>