[node-patches] Change in ovirt-node[master]: ovirt-node-upgrade: fix logfile name

[Alon Bar-Lev]

Alon Bar-Lev has posted comments on this change.

Change subject: ovirt-node-upgrade: fix logfile name
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File scripts/ovirt-node-upgrade.py
Line 49: 
Line 50: 
Line 51: def initLogger():
Line 52:     logger = logging.getLogger(LOG_PREFIX)
Line 53:     log_file = "/var/log/ovirt-node-upgrade.log"
I don't think so...

If we keep log per iteration, log should be provided in cmdline... --log ... and not have anything at /var/log.

If we want to track logs and able to logrotate and such, a single log at /var/log is to be available.
Line 54:     formatter = logging.Formatter(fmt='%(asctime)s - %(levelname)-8s - '
Line 55:                                   '%(module)s - %(message)s')
Line 56:     conformatter = logging.Formatter('%(name)-12s: %(levelname)-8s'
Line 57:                                      ' %(message)s')


--
To view, visit http://gerrit.ovirt.org/14956
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I37ff3ecedc0f1e4d67e822a64686846fbac3b52e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>