[node-patches] Change in ovirt-node[puppet-ovirt-node-plugin]: Initial push of puppet plugin code to ovirt repo

mburns at redhat.com mburns at redhat.com
Thu May 23 18:52:47 UTC 2013


Michael Burns has posted comments on this change.

Change subject: Initial push of puppet plugin code to ovirt repo
......................................................................


Patch Set 2: Do not submit

Some very high level comments:

* Don't include the tar.gz in the git repo
* Need to merge specfile into ovirt-node.spec
* same for configure.ac/autogen.sh/etc...
* you submitted src/ovirt/node/setup/.logging_page.py.swp which shouldn't be included

--
To view, visit http://gerrit.ovirt.org/14664
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb639acf019a48e809fb983ab2124c6215c00157
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: puppet-ovirt-node-plugin
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>



More information about the node-patches mailing list