[node-patches] Change in ovirt-node[master]: app: Move plugins into their own namespace

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: app: Move plugins into their own namespace
......................................................................


Patch Set 12: (1 inline comment)

....................................................
File src/ovirt/node/plugins.py
Line 66:             yield __import_by_modname(modpath)
Line 67: 
Line 68: 
Line 69: def __import_by_modname(modpath):
Line 70:     return __import__(modpath, fromlist="dummy")
Thanks, I looked around a bit and decided to use pkgutil. Or is there any special reason to use imp? pkgutil seems to be a higher-level api around imp.
Line 71: 
Line 72: 
Line 73: def get_modules_in_package(package, filter_cb=lambda n: True):
Line 74:     """Get and load all modules in a package


--
To view, visit http://gerrit.ovirt.org/15046
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icaf10816d1c87d9d0404130f496f0f6cad13149a
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>