[node-patches] Change in ovirt-node[master]: Declare non-initialized variable in _create_manifests

ramonn at linux.vnet.ibm.com ramonn at linux.vnet.ibm.com
Fri May 24 20:36:36 UTC 2013


Ramon Medeiros has uploaded a new change for review.

Change subject: Declare non-initialized variable in _create_manifests
......................................................................

Declare non-initialized variable in _create_manifests

Declare the variable pkg, that was being declared after conditional
statements. So, if the conditional statement was not confirmed, will be
raise UndeclaredReference. This fix avoid it.

Change-Id: I4c095c03c0f773f54ae263d57ce979b9a1b5e632
Signed-off-by: Ramon Medeiros <ramonn at linux.vnet.ibm.com>
---
M tools/edit-node
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/58/15058/1

diff --git a/tools/edit-node b/tools/edit-node
index db1b576..8927edf 100755
--- a/tools/edit-node
+++ b/tools/edit-node
@@ -735,6 +735,7 @@
         return True
 
     def _create_manifests(self, options):
+        pkg = ""
         timestamp = date("%Y-%m-%d_%H-%M-%S")
         if options.plugin:
             pkg = options.plugin


--
To view, visit http://gerrit.ovirt.org/15058
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4c095c03c0f773f54ae263d57ce979b9a1b5e632
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ramon Medeiros <ramonn at linux.vnet.ibm.com>



More information about the node-patches mailing list