[node-patches] Change in ovirt-node[master]: tui: swap dictConfig to fileConfig based logging for 2.6 pyc...

fabiand at fedoraproject.org fabiand at fedoraproject.org
Mon May 27 09:01:38 UTC 2013


Fabian Deutsch has posted comments on this change.

Change subject: tui: swap dictConfig to fileConfig based logging for 2.6 pycompat
......................................................................


Patch Set 2: (1 inline comment)

Fine, except the conf location.

....................................................
File ovirt-node.spec.in
Line 487: %endif
Line 488: %if ! %{is_systemd}
Line 489: %{_sysconfdir}/init/libvirtd.conf
Line 490: %endif
Line 491: %{_sysconfdir}/sysconfig/ovirt-logging.conf
I'd rather like to use /etc/ovirt-node/logging.conf instead.
We should also migrate /etc/sysconfig/ovirt /to this dir, to have some sort of FHS conformance.
Line 492: %{_sysconfdir}/sysconfig/modules/vlan.modules
Line 493: %{_sysconfdir}/modprobe.d/ovirt-qla4xxx.conf
Line 494: %{_libexecdir}/ovirt-node/hooks
Line 495: 


--
To view, visit http://gerrit.ovirt.org/15045
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib57350d7a6b62a75a31b59545a2552ed64013b7f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>



More information about the node-patches mailing list